Browse Source

drm/atomic: Delete an unnecessary check before drm_property_unreference_blob()

The drm_property_unreference_blob() function tests whether its argument
is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/aa4cd508-38c3-78d7-a9f2-70e3b06a8fb5@users.sourceforge.net
Markus Elfring 9 years ago
parent
commit
f35cbe6a17
1 changed files with 1 additions and 2 deletions
  1. 1 2
      drivers/gpu/drm/drm_atomic.c

+ 1 - 2
drivers/gpu/drm/drm_atomic.c

@@ -404,8 +404,7 @@ drm_atomic_replace_property_blob(struct drm_property_blob **blob,
 	if (old_blob == new_blob)
 	if (old_blob == new_blob)
 		return;
 		return;
 
 
-	if (old_blob)
-		drm_property_unreference_blob(old_blob);
+	drm_property_unreference_blob(old_blob);
 	if (new_blob)
 	if (new_blob)
 		drm_property_reference_blob(new_blob);
 		drm_property_reference_blob(new_blob);
 	*blob = new_blob;
 	*blob = new_blob;