瀏覽代碼

tpm: st33zp24: remove redundant null check on chip

Currently chip is being dereferenced by the call to dev_get_drvdata
before it is being null checked, however, chip can never be null, so
this check is misleading and redundant. Remove it.

Detected by CoverityScan, CID#1357806 ("Dereference before null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jarkko Sakkinen <jarkkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkkko.sakkinen@linux.intel.com>
Colin Ian King 7 年之前
父節點
當前提交
f20b4f2245
共有 1 個文件被更改,包括 0 次插入2 次删除
  1. 0 2
      drivers/char/tpm/st33zp24/st33zp24.c

+ 0 - 2
drivers/char/tpm/st33zp24/st33zp24.c

@@ -373,8 +373,6 @@ static int st33zp24_send(struct tpm_chip *chip, unsigned char *buf,
 	int ret;
 	u8 data;
 
-	if (!chip)
-		return -EBUSY;
 	if (len < TPM_HEADER_SIZE)
 		return -EBUSY;