Pārlūkot izejas kodu

net: ucc_geth: make probe consistently acquire a reference to the phy node

When the driver attaches to a device that has a phy handle the probe
routine returns with a reference to that node. This reference is
correctly dropped in the error path and the remove function. In the
fixed phy case however no reference is acquired and so the error path
might drop a reference the driver isn't holding. Fix that by getting a
reference to the MAC.

Fixes: 87009814cdbb ("ucc_geth: use the new fixed PHY helpers")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Uwe Kleine-König 11 gadi atpakaļ
vecāks
revīzija
f1f02fa4f1
1 mainītis faili ar 1 papildinājumiem un 1 dzēšanām
  1. 1 1
      drivers/net/ethernet/freescale/ucc_geth.c

+ 1 - 1
drivers/net/ethernet/freescale/ucc_geth.c

@@ -3794,7 +3794,7 @@ static int ucc_geth_probe(struct platform_device* ofdev)
 			if (err)
 			if (err)
 				return err;
 				return err;
 		}
 		}
-		ug_info->phy_node = np;
+		ug_info->phy_node = of_node_get(np);
 	}
 	}
 
 
 	/* Find the TBI PHY node.  If it's not there, we don't support SGMII */
 	/* Find the TBI PHY node.  If it's not there, we don't support SGMII */