base: soc: use put_device() instead of kfree() · ef49ec1dc3 - Gogs: Go Git Service GfA electronic

base: soc: use put_device() instead of kfree()

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Arvind Yadav 7 years ago

parent

9de9a44948

commit

ef49ec1dc3

1 changed files with 2 additions and 0 deletions

Split View Show Diff Stats

						
							+ 2
							
							- 0
						
drivers/base/soc.c
							 
								View File
							
				@@ -150,6 +150,8 @@ struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr
			
				 out3:
			
				 	ida_simple_remove(&soc_ida, soc_dev->soc_dev_num);
			
				+	put_device(&soc_dev->dev);
			
				+	soc_dev = NULL;
			
				 out2:
			
				 	kfree(soc_dev);
			
				 out1: