Przeglądaj źródła

scsi: fc: remove redundant check of an unsigned long being less than zero

The check for an unsigned long being less than zero is always false so
it is a redundant check and can be removed.

Detected by static analysis with by PVS-Studio

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Colin Ian King 8 lat temu
rodzic
commit
eea422709f
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      drivers/scsi/scsi_transport_fc.c

+ 1 - 1
drivers/scsi/scsi_transport_fc.c

@@ -850,7 +850,7 @@ static int fc_str_to_dev_loss(const char *buf, unsigned long *val)
 	char *cp;
 	char *cp;
 
 
 	*val = simple_strtoul(buf, &cp, 0);
 	*val = simple_strtoul(buf, &cp, 0);
-	if ((*cp && (*cp != '\n')) || (*val < 0))
+	if (*cp && (*cp != '\n'))
 		return -EINVAL;
 		return -EINVAL;
 	/*
 	/*
 	 * Check for overflow; dev_loss_tmo is u32
 	 * Check for overflow; dev_loss_tmo is u32