Browse Source

drm: qxl: add missing return check

My static checker complains that "release" is uninitialized if
qxl_alloc_release_reserved() fails, so let's add a check for that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170314075410.GB5984@mwanda
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Dan Carpenter 8 năm trước cách đây
mục cha
commit
ee5cb7c465
1 tập tin đã thay đổi với 2 bổ sung0 xóa
  1. 2 0
      drivers/gpu/drm/qxl/qxl_display.c

+ 2 - 0
drivers/gpu/drm/qxl/qxl_display.c

@@ -572,6 +572,8 @@ static void qxl_cursor_atomic_update(struct drm_plane *plane,
 	ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
 	ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd),
 					 QXL_RELEASE_CURSOR_CMD,
 					 QXL_RELEASE_CURSOR_CMD,
 					 &release, NULL);
 					 &release, NULL);
+	if (ret)
+		return;
 
 
 	cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);
 	cmd = (struct qxl_cursor_cmd *) qxl_release_map(qdev, release);