Browse Source

iio: accel: sca3000: memory corruption in sca3000_read_first_n_hw_rb()

"num_read" is in byte units but we are write u16s so we end up write
twice as much as intended.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Dan Carpenter 10 years ago
parent
commit
eda7d0f38a
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/staging/iio/accel/sca3000_ring.c

+ 1 - 1
drivers/staging/iio/accel/sca3000_ring.c

@@ -116,7 +116,7 @@ static int sca3000_read_first_n_hw_rb(struct iio_buffer *r,
 	if (ret)
 		goto error_ret;
 
-	for (i = 0; i < num_read; i++)
+	for (i = 0; i < num_read / sizeof(u16); i++)
 		*(((u16 *)rx) + i) = be16_to_cpup((__be16 *)rx + i);
 
 	if (copy_to_user(buf, rx, num_read))