Quellcode durchsuchen

mlxsw: spectrum_kvdl: avoid uninitialized variable warning

gcc warns that 'resource_id' is not initialized if we don't come though
any of the three 'case' statements before:

drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c: In function 'mlxsw_sp_kvdl_part_init':
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:275:8: error: 'resource_id' may be used uninitialized in this function [-Werror=maybe-uninitialized]

In the current code, that won't happen, but it's more robust to explicitly
handle this by returning a failure from mlxsw_sp_kvdl_part_init.

Fixes: 887839e6960d ("mlxsw: spectrum_kvdl: Add support for dynamic partition set")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Arnd Bergmann vor 7 Jahren
Ursprung
Commit
ed2da6270e
1 geänderte Dateien mit 2 neuen und 0 gelöschten Zeilen
  1. 2 0
      drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c

+ 2 - 0
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c

@@ -270,6 +270,8 @@ static int mlxsw_sp_kvdl_part_init(struct mlxsw_sp *mlxsw_sp,
 	case MLXSW_SP_KVDL_PART_LARGE_CHUNKS:
 	case MLXSW_SP_KVDL_PART_LARGE_CHUNKS:
 		resource_id = MLXSW_SP_RESOURCE_KVD_LINEAR_LARGE_CHUNKS;
 		resource_id = MLXSW_SP_RESOURCE_KVD_LINEAR_LARGE_CHUNKS;
 		break;
 		break;
+	default:
+		return -EINVAL;
 	}
 	}
 
 
 	err = devlink_resource_size_get(devlink, resource_id, &resource_size);
 	err = devlink_resource_size_get(devlink, resource_id, &resource_size);