Bläddra i källkod

SUNRPC: off by one in BUG_ON()

The m->pool_to[] array has "maxpools" number of elements.  It's
allocated in svc_pool_map_alloc_arrays() which we called earlier in the
function.  This test should be >= instead of >.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Dan Carpenter 10 år sedan
förälder
incheckning
eb63192bb8
1 ändrade filer med 1 tillägg och 1 borttagningar
  1. 1 1
      net/sunrpc/svc.c

+ 1 - 1
net/sunrpc/svc.c

@@ -189,7 +189,7 @@ svc_pool_map_init_percpu(struct svc_pool_map *m)
 		return err;
 		return err;
 
 
 	for_each_online_cpu(cpu) {
 	for_each_online_cpu(cpu) {
-		BUG_ON(pidx > maxpools);
+		BUG_ON(pidx >= maxpools);
 		m->to_pool[cpu] = pidx;
 		m->to_pool[cpu] = pidx;
 		m->pool_to[pidx] = cpu;
 		m->pool_to[pidx] = cpu;
 		pidx++;
 		pidx++;