Browse Source

xen: make use of xenbus_read_unsigned() in xen-fbfront

Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
This requires to change the type of the reads from int to unsigned,
but these cases have been wrong before: negative values are not allowed
for the modified cases.

Cc: tomi.valkeinen@ti.com
Cc: linux-fbdev@vger.kernel.org

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: David Vrabel <david.vrabel@citrix.com>
Juergen Gross 8 years ago
parent
commit
eaf46e181e
1 changed files with 4 additions and 9 deletions
  1. 4 9
      drivers/video/fbdev/xen-fbfront.c

+ 4 - 9
drivers/video/fbdev/xen-fbfront.c

@@ -633,7 +633,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
 				  enum xenbus_state backend_state)
 				  enum xenbus_state backend_state)
 {
 {
 	struct xenfb_info *info = dev_get_drvdata(&dev->dev);
 	struct xenfb_info *info = dev_get_drvdata(&dev->dev);
-	int val;
 
 
 	switch (backend_state) {
 	switch (backend_state) {
 	case XenbusStateInitialising:
 	case XenbusStateInitialising:
@@ -657,16 +656,12 @@ InitWait:
 		if (dev->state != XenbusStateConnected)
 		if (dev->state != XenbusStateConnected)
 			goto InitWait; /* no InitWait seen yet, fudge it */
 			goto InitWait; /* no InitWait seen yet, fudge it */
 
 
-		if (xenbus_scanf(XBT_NIL, info->xbdev->otherend,
-				 "request-update", "%d", &val) < 0)
-			val = 0;
-		if (val)
+		if (xenbus_read_unsigned(info->xbdev->otherend,
+					 "request-update", 0))
 			info->update_wanted = 1;
 			info->update_wanted = 1;
 
 
-		if (xenbus_scanf(XBT_NIL, dev->otherend,
-				 "feature-resize", "%d", &val) < 0)
-			val = 0;
-		info->feature_resize = val;
+		info->feature_resize = xenbus_read_unsigned(dev->otherend,
+							"feature-resize", 0);
 		break;
 		break;
 
 
 	case XenbusStateClosed:
 	case XenbusStateClosed: