浏览代码

arm64: sdei: Mark sdei stack helper functions as static

The SDEI stack helper functions are only used by _on_sdei_stack() and
refer to symbols (e.g. sdei_stack_normal_ptr) that are only defined if
CONFIG_VMAP_STACK=y.

Mark these functions as static, so we don't run into errors at link-time
due to references to undefined symbols. Stick all the parameters onto
the same line whilst we're passing through.

Signed-off-by: Will Deacon <will.deacon@arm.com>
Will Deacon 7 年之前
父节点
当前提交
eab1cecc12
共有 1 个文件被更改,包括 3 次插入6 次删除
  1. 3 6
      arch/arm64/kernel/sdei.c

+ 3 - 6
arch/arm64/kernel/sdei.c

@@ -89,8 +89,7 @@ static int init_sdei_stacks(void)
 	return err;
 }
 
-bool on_sdei_normal_stack(unsigned long sp,
-			struct stack_info *info)
+static bool on_sdei_normal_stack(unsigned long sp, struct stack_info *info)
 {
 	unsigned long low = (unsigned long)raw_cpu_read(sdei_stack_normal_ptr);
 	unsigned long high = low + SDEI_STACK_SIZE;
@@ -107,8 +106,7 @@ bool on_sdei_normal_stack(unsigned long sp,
 	return true;
 }
 
-bool on_sdei_critical_stack(unsigned long sp,
-			struct stack_info *info)
+static bool on_sdei_critical_stack(unsigned long sp, struct stack_info *info)
 {
 	unsigned long low = (unsigned long)raw_cpu_read(sdei_stack_critical_ptr);
 	unsigned long high = low + SDEI_STACK_SIZE;
@@ -125,8 +123,7 @@ bool on_sdei_critical_stack(unsigned long sp,
 	return true;
 }
 
-bool _on_sdei_stack(unsigned long sp,
-		struct stack_info *info)
+bool _on_sdei_stack(unsigned long sp, struct stack_info *info)
 {
 	if (!IS_ENABLED(CONFIG_VMAP_STACK))
 		return false;