Browse Source

Input: matrix_keypad - fix race when disabling interrupts

If matrix_keypad_stop() is executing and the keypad interrupt is triggered,
disable_row_irqs() may be called by both matrix_keypad_interrupt() and
matrix_keypad_stop() at the same time, causing interrupts to be disabled
twice and the keypad being "stuck" after resuming.

Take lock when setting keypad->stopped to ensure that ISR will not race
with matrix_keypad_stop() disabling interrupts.

Signed-off-by: Zhang Bo <zbsdta@126.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Zhang Bo 7 years ago
parent
commit
ea4f7bd2ac
1 changed files with 3 additions and 1 deletions
  1. 3 1
      drivers/input/keyboard/matrix_keypad.c

+ 3 - 1
drivers/input/keyboard/matrix_keypad.c

@@ -218,8 +218,10 @@ static void matrix_keypad_stop(struct input_dev *dev)
 {
 {
 	struct matrix_keypad *keypad = input_get_drvdata(dev);
 	struct matrix_keypad *keypad = input_get_drvdata(dev);
 
 
+	spin_lock_irq(&keypad->lock);
 	keypad->stopped = true;
 	keypad->stopped = true;
-	mb();
+	spin_unlock_irq(&keypad->lock);
+
 	flush_work(&keypad->work.work);
 	flush_work(&keypad->work.work);
 	/*
 	/*
 	 * matrix_keypad_scan() will leave IRQs enabled;
 	 * matrix_keypad_scan() will leave IRQs enabled;