Эх сурвалжийг харах

staging:rtl8187se: Fix sparse warning restricted __le16 degrades to integer

This patch fixes the following sparse warning in r8180_core.c - warning:
restricted __le16 degrades to integer. Also, the variable morefrag is
changed to bool as it is being used as a bool.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Reviewed-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi 11 жил өмнө
parent
commit
e95f6dfbcf

+ 2 - 2
drivers/staging/rtl8187se/r8180_core.c

@@ -1579,7 +1579,7 @@ static void rtl8180_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
 	struct r8180_priv *priv = (struct r8180_priv *)ieee80211_priv(dev);
 	int mode;
 	struct ieee80211_hdr_3addr *h = (struct ieee80211_hdr_3addr *)skb->data;
-	short morefrag = (h->frame_control) & IEEE80211_FCTL_MOREFRAGS;
+	bool morefrag = le16_to_cpu(h->frame_control) & IEEE80211_FCTL_MOREFRAGS;
 	unsigned long flags;
 	int priority;
 
@@ -1807,7 +1807,7 @@ short rtl8180_tx(struct net_device *dev, u8 *txbuf, int len, int priority,
 			TxDescDuration = ThisFrameTime + aSifsTime + AckTime;
 		}
 
-		if (!(frag_hdr->frame_control & IEEE80211_FCTL_MOREFRAGS)) {
+		if (!(le16_to_cpu(frag_hdr->frame_control) & IEEE80211_FCTL_MOREFRAGS)) {
 			/* ThisFrame-ACK. */
 			Duration = aSifsTime + AckTime;
 		} else { /* One or more fragments remained. */