فهرست منبع

[media] DaVinci-VPFE-Capture: Replace a memcpy() call by an assignment in vpfe_enum_input()

Use a direct assignment for an array element which can be set over the
pointer variable "inp" instead of calling the function "memcpy" here.

Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Markus Elfring 8 سال پیش
والد
کامیت
e91b6006bf
1فایلهای تغییر یافته به همراه1 افزوده شده و 1 حذف شده
  1. 1 1
      drivers/media/platform/davinci/vpfe_capture.c

+ 1 - 1
drivers/media/platform/davinci/vpfe_capture.c

@@ -1086,7 +1086,7 @@ static int vpfe_enum_input(struct file *file, void *priv,
 		return -EINVAL;
 		return -EINVAL;
 	}
 	}
 	sdinfo = &vpfe_dev->cfg->sub_devs[subdev];
 	sdinfo = &vpfe_dev->cfg->sub_devs[subdev];
-	memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input));
+	*inp = sdinfo->inputs[index];
 	return 0;
 	return 0;
 }
 }