浏览代码

ubifs: ensure zero err is returned on successful return

err is no longer being set on a successful return path, causing
a garbage value being returned. Fix this by setting err to zero
for the successful return path.

Found with static analysis by CoverityScan, CID 1389473

Fixes: 7799953b34d18 ("ubifs: Implement encrypt/decrypt for all IO")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Colin Ian King 8 年之前
父节点
当前提交
e8f19746e4
共有 1 个文件被更改,包括 1 次插入0 次删除
  1. 1 0
      fs/ubifs/journal.c

+ 1 - 0
fs/ubifs/journal.c

@@ -1319,6 +1319,7 @@ static int truncate_data_node(const struct ubifs_info *c, const struct inode *in
 	dn->compr_type = cpu_to_le16(compr_type);
 	dn->compr_type = cpu_to_le16(compr_type);
 	dn->size = cpu_to_le32(*new_len);
 	dn->size = cpu_to_le32(*new_len);
 	*new_len = UBIFS_DATA_NODE_SZ + out_len;
 	*new_len = UBIFS_DATA_NODE_SZ + out_len;
+	err = 0;
 out:
 out:
 	kfree(buf);
 	kfree(buf);
 	return err;
 	return err;