Parcourir la source

hwmon: (nct6775) Use return value from find_temp_source

smatch complains that we don't use the return value from find_temp_source().
Valid point, only find_temp_source() doesn't return a valid error code.
Have it return a valid error code and use it.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Guenter Roeck il y a 12 ans
Parent
commit
e8ab508c27
1 fichiers modifiés avec 2 ajouts et 2 suppressions
  1. 2 2
      drivers/hwmon/nct6775.c

+ 2 - 2
drivers/hwmon/nct6775.c

@@ -1545,7 +1545,7 @@ static int find_temp_source(struct nct6775_data *data, int index, int count)
 		if (src == source)
 		if (src == source)
 			return nr;
 			return nr;
 	}
 	}
-	return -1;
+	return -ENODEV;
 }
 }
 
 
 static ssize_t
 static ssize_t
@@ -1644,7 +1644,7 @@ store_temp_beep(struct device *dev, struct device_attribute *attr,
 
 
 	nr = find_temp_source(data, sattr->index, data->num_temp_beeps);
 	nr = find_temp_source(data, sattr->index, data->num_temp_beeps);
 	if (nr < 0)
 	if (nr < 0)
-		return -ENODEV;
+		return nr;
 
 
 	bit = data->BEEP_BITS[nr + TEMP_ALARM_BASE];
 	bit = data->BEEP_BITS[nr + TEMP_ALARM_BASE];
 	regindex = bit >> 3;
 	regindex = bit >> 3;