소스 검색

drivers: fix dma_get_required_mask

There's a bug in the current implementation of dma_get_required_mask()
where it ands the returned mask with the current device mask.  This
rather defeats the purpose if you're using the call to determine what
your mask should be (since you will at that time have the default
DMA_32BIT_MASK).  This bug results in any driver that uses this function
*always* getting a 32 bit mask, which is wrong.

Fix by removing the and with dev->dma_mask.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
James Bottomley 17 년 전
부모
커밋
e88a0c2ca8
1개의 변경된 파일1개의 추가작업 그리고 1개의 파일을 삭제
  1. 1 1
      drivers/base/platform.c

+ 1 - 1
drivers/base/platform.c

@@ -648,7 +648,7 @@ u64 dma_get_required_mask(struct device *dev)
 		high_totalram += high_totalram - 1;
 		high_totalram += high_totalram - 1;
 		mask = (((u64)high_totalram) << 32) + 0xffffffff;
 		mask = (((u64)high_totalram) << 32) + 0xffffffff;
 	}
 	}
-	return mask & *dev->dma_mask;
+	return mask;
 }
 }
 EXPORT_SYMBOL_GPL(dma_get_required_mask);
 EXPORT_SYMBOL_GPL(dma_get_required_mask);
 #endif
 #endif