Просмотр исходного кода

pinctrl: ingenic: checking for NULL instead of IS_ERR()

devm_pinctrl_register() returns error pointers, it doesn't return NULL.

Fixes: b5c23aa46537 ("pinctrl: add a pinctrl driver for the Ingenic jz47xx SoCs")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Dan Carpenter 8 лет назад
Родитель
Сommit
e7f4c4bf99
1 измененных файлов с 2 добавлено и 2 удалено
  1. 2 2
      drivers/pinctrl/pinctrl-ingenic.c

+ 2 - 2
drivers/pinctrl/pinctrl-ingenic.c

@@ -785,9 +785,9 @@ int ingenic_pinctrl_probe(struct platform_device *pdev)
 	}
 
 	jzpc->pctl = devm_pinctrl_register(dev, pctl_desc, jzpc);
-	if (!jzpc->pctl) {
+	if (IS_ERR(jzpc->pctl)) {
 		dev_err(dev, "Failed to register pinctrl\n");
-		return -EINVAL;
+		return PTR_ERR(jzpc->pctl);
 	}
 
 	for (i = 0; i < chip_info->num_groups; i++) {