浏览代码

cpufreq: stats: don't update stats on false notifiers

We need to call cpufreq_stats_update() to update 'time_in_state' for the last
frequency. This is achieved by calling it from cpufreq_stat_notifier_trans(),
which is called after frequency transition.

But if we detect that the cpu's frequency haven't really changed and its a false
POSTCHANGE notification, we don't really need to update time_in_state.

It wouldn't cause any harm in calling cpufreq_stats_update() but we can avoid
calling it here and call it when the frequency really changes. The result will
be the same but more efficient.

Reviewed-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Viresh Kumar 10 年之前
父节点
当前提交
e73476949c
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/cpufreq/cpufreq_stats.c

+ 2 - 2
drivers/cpufreq/cpufreq_stats.c

@@ -289,11 +289,11 @@ static int cpufreq_stat_notifier_trans(struct notifier_block *nb,
 	if (old_index == -1 || new_index == -1)
 	if (old_index == -1 || new_index == -1)
 		goto put_policy;
 		goto put_policy;
 
 
-	cpufreq_stats_update(stats);
-
 	if (old_index == new_index)
 	if (old_index == new_index)
 		goto put_policy;
 		goto put_policy;
 
 
+	cpufreq_stats_update(stats);
+
 	spin_lock(&cpufreq_stats_lock);
 	spin_lock(&cpufreq_stats_lock);
 	stats->last_index = new_index;
 	stats->last_index = new_index;
 #ifdef CONFIG_CPU_FREQ_STAT_DETAILS
 #ifdef CONFIG_CPU_FREQ_STAT_DETAILS