ソースを参照

fm10k: fix PCI device enable_cnt leak in .io_slot_reset

A previous patch removed the pci_disable_device() call in
.io_error_detected. This call corresponded to a pci_enable_device_mem()
call within .io_slot_reset handler. Change the call here to
a pci_reenable_device() so that it does not increment and leak the
enable_cnt reference count for the device. Without this change, VF
devices may fail during an unbind/bind, and we'll never zero the
reference counter for the pci_dev structure.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Jacob Keller 9 年 前
コミット
e59a393d08
1 ファイル変更1 行追加1 行削除
  1. 1 1
      drivers/net/ethernet/intel/fm10k/fm10k_pci.c

+ 1 - 1
drivers/net/ethernet/intel/fm10k/fm10k_pci.c

@@ -2275,7 +2275,7 @@ static pci_ers_result_t fm10k_io_slot_reset(struct pci_dev *pdev)
 {
 {
 	pci_ers_result_t result;
 	pci_ers_result_t result;
 
 
-	if (pci_enable_device_mem(pdev)) {
+	if (pci_reenable_device(pdev)) {
 		dev_err(&pdev->dev,
 		dev_err(&pdev->dev,
 			"Cannot re-enable PCI device after reset.\n");
 			"Cannot re-enable PCI device after reset.\n");
 		result = PCI_ERS_RESULT_DISCONNECT;
 		result = PCI_ERS_RESULT_DISCONNECT;