ソースを参照

gpio: sysfs: clean up edge_store

Remove goto from success path.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Johan Hovold 10 年 前
コミット
e4339ce323
1 ファイル変更7 行追加5 行削除
  1. 7 5
      drivers/gpio/gpiolib-sysfs.c

+ 7 - 5
drivers/gpio/gpiolib-sysfs.c

@@ -236,14 +236,16 @@ static ssize_t edge_store(struct device *dev,
 	struct gpio_desc *desc = data->desc;
 	struct gpio_desc *desc = data->desc;
 	unsigned long flags;
 	unsigned long flags;
 	ssize_t	status = size;
 	ssize_t	status = size;
-	int			i;
+	int i;
 
 
-	for (i = 0; i < ARRAY_SIZE(trigger_types); i++)
+	for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
 		if (sysfs_streq(trigger_types[i].name, buf))
 		if (sysfs_streq(trigger_types[i].name, buf))
-			goto found;
-	return -EINVAL;
+			break;
+	}
+
+	if (i == ARRAY_SIZE(trigger_types))
+		return -EINVAL;
 
 
-found:
 	flags = trigger_types[i].flags;
 	flags = trigger_types[i].flags;
 
 
 	mutex_lock(&sysfs_lock);
 	mutex_lock(&sysfs_lock);