Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

IB/uverbs: Add missing braces in anonymous union initializers

With gcc-4.1.2:

    drivers/infiniband/core/uverbs_std_types_flow_action.c:366: error: unknown field ‘ptr’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:367: error: unknown field ‘type’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:367: warning: missing braces around initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:367: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0].<anonymous>.<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:368: error: unknown field ‘min_len’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: excess elements in union initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0].<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:368: error: unknown field ‘len’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: excess elements in union initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:368: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0].<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:369: error: unknown field ‘flags’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:369: warning: excess elements in union initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:369: warning: (near initialization for ‘uverbs_flow_action_esp_keymat[0].<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:376: error: unknown field ‘ptr’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:377: error: unknown field ‘type’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:377: warning: missing braces around initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:377: warning: (near initialization for ‘uverbs_flow_action_esp_replay[0].<anonymous>.<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:379: error: unknown field ‘len’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:379: warning: excess elements in union initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:379: warning: (near initialization for ‘uverbs_flow_action_esp_replay[0].<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:383: error: unknown field ‘ptr’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:384: error: unknown field ‘type’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:385: error: unknown field ‘min_len’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: excess elements in union initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: (near initialization for ‘uverbs_flow_action_esp_replay[1].<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:385: error: unknown field ‘len’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: excess elements in union initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:385: warning: (near initialization for ‘uverbs_flow_action_esp_replay[1].<anonymous>’)
    drivers/infiniband/core/uverbs_std_types_flow_action.c:386: error: unknown field ‘flags’ specified in initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:386: warning: excess elements in union initializer
    drivers/infiniband/core/uverbs_std_types_flow_action.c:386: warning: (near initialization for ‘uverbs_flow_action_esp_replay[1].<anonymous>’)

Add the missing braces to fix this.

Fixes: 2eb9beaee5d7 ("IB/uverbs: Add flow_action create and destroy verbs")
Fixes: 7d12f8d5a164 ("IB/uverbs: Add modify ESP flow_action")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Geert Uytterhoeven 7 years ago
parent
b3fe6c62bc
commit
e33514f2e9
1 changed files with 6 additions and 6 deletions
Unified View Show Diff Stats
  1. 6 6
      drivers/infiniband/core/uverbs_std_types_flow_action.c

+ 6 - 6
drivers/infiniband/core/uverbs_std_types_flow_action.c
View File 

@@ -363,28 +363,28 @@ static int UVERBS_HANDLER(UVERBS_METHOD_FLOW_ACTION_ESP_MODIFY)(struct ib_device
 
 
 
 static const struct uverbs_attr_spec uverbs_flow_action_esp_keymat[] = {
 
 static const struct uverbs_attr_spec uverbs_flow_action_esp_keymat[] = {
 
 	[IB_UVERBS_FLOW_ACTION_ESP_KEYMAT_AES_GCM] = {
 
 	[IB_UVERBS_FLOW_ACTION_ESP_KEYMAT_AES_GCM] = {
 
-		.ptr = {
 
+		{ .ptr = {
 
 			.type = UVERBS_ATTR_TYPE_PTR_IN,
 
 			.type = UVERBS_ATTR_TYPE_PTR_IN,
 
 			UVERBS_ATTR_TYPE(struct ib_uverbs_flow_action_esp_keymat_aes_gcm),
 
 			UVERBS_ATTR_TYPE(struct ib_uverbs_flow_action_esp_keymat_aes_gcm),
 
 			.flags = UVERBS_ATTR_SPEC_F_MIN_SZ_OR_ZERO,
 
 			.flags = UVERBS_ATTR_SPEC_F_MIN_SZ_OR_ZERO,
 
-		},
 
+		} },
 
 	},
 
 	},
 
 };
 
 };
 
 
 
 static const struct uverbs_attr_spec uverbs_flow_action_esp_replay[] = {
 
 static const struct uverbs_attr_spec uverbs_flow_action_esp_replay[] = {
 
 	[IB_UVERBS_FLOW_ACTION_ESP_REPLAY_NONE] = {
 
 	[IB_UVERBS_FLOW_ACTION_ESP_REPLAY_NONE] = {
 
-		.ptr = {
 
+		{ .ptr = {
 
 			.type = UVERBS_ATTR_TYPE_PTR_IN,
 
 			.type = UVERBS_ATTR_TYPE_PTR_IN,
 
 			/* No need to specify any data */
 
 			/* No need to specify any data */
 
 			.len = 0,
 
 			.len = 0,
 
-		}
 
+		} }
 
 	},
 
 	},
 
 	[IB_UVERBS_FLOW_ACTION_ESP_REPLAY_BMP] = {
 
 	[IB_UVERBS_FLOW_ACTION_ESP_REPLAY_BMP] = {
 
-		.ptr = {
 
+		{ .ptr = {
 
 			.type = UVERBS_ATTR_TYPE_PTR_IN,
 
 			.type = UVERBS_ATTR_TYPE_PTR_IN,
 
 			UVERBS_ATTR_STRUCT(struct ib_uverbs_flow_action_esp_replay_bmp, size),
 
 			UVERBS_ATTR_STRUCT(struct ib_uverbs_flow_action_esp_replay_bmp, size),
 
 			.flags = UVERBS_ATTR_SPEC_F_MIN_SZ_OR_ZERO,
 
 			.flags = UVERBS_ATTR_SPEC_F_MIN_SZ_OR_ZERO,
 
-		}
 
+		} }
 
 	},
 
 	},
 
 };
 
 };