Explorar o código

hwmon: (jc42) Fix integer overflow when writing hysteresis value

Subtracting an unsigned long from a signed value causes an overflow with large
values. Use clamp_val() to reduce the number range prior to subtracting it
from the temperature limit.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Guenter Roeck %!s(int64=10) %!d(string=hai) anos
pai
achega
e2c26f058e
Modificáronse 1 ficheiros con 2 adicións e 0 borrados
  1. 2 0
      drivers/hwmon/jc42.c

+ 2 - 0
drivers/hwmon/jc42.c

@@ -312,7 +312,9 @@ static ssize_t set_temp_crit_hyst(struct device *dev,
 	if (kstrtoul(buf, 10, &val) < 0)
 		return -EINVAL;
 
+	val = clamp_val(val, 0, JC42_TEMP_MAX);
 	diff = jc42_temp_from_reg(data->temp[t_crit]) - val;
+
 	hyst = 0;
 	if (diff > 0) {
 		if (diff < 2250)