Przeglądaj źródła

net: dsa: mv88e6xxx: missing unlock on error path

We added a new error path, but we need to drop the lock before we return.

Fixes: 2d2e1dd29962 ("net: dsa: mv88e6xxx: Cache the port cmode")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter 7 lat temu
rodzic
commit
e29129fcac
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      drivers/net/dsa/mv88e6xxx/chip.c

+ 1 - 1
drivers/net/dsa/mv88e6xxx/chip.c

@@ -2408,7 +2408,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
 		if (chip->info->ops->port_get_cmode) {
 		if (chip->info->ops->port_get_cmode) {
 			err = chip->info->ops->port_get_cmode(chip, i, &cmode);
 			err = chip->info->ops->port_get_cmode(chip, i, &cmode);
 			if (err)
 			if (err)
-				return err;
+				goto unlock;
 
 
 			chip->ports[i].cmode = cmode;
 			chip->ports[i].cmode = cmode;
 		}
 		}