瀏覽代碼

USB iowarrior.c: fix check-after-use

The Coverity checker spotted that we have already oops'ed if "dev"
was NULL.

Since "dev" being NULL doesn't seem to be possible here this patch 
removes the NULL check.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Adrian Bunk 18 年之前
父節點
當前提交
e28c6a7706
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/usb/misc/iowarrior.c

+ 1 - 1
drivers/usb/misc/iowarrior.c

@@ -351,7 +351,7 @@ static ssize_t iowarrior_write(struct file *file,
 
 
 	mutex_lock(&dev->mutex);
 	mutex_lock(&dev->mutex);
 	/* verify that the device wasn't unplugged */
 	/* verify that the device wasn't unplugged */
-	if (dev == NULL || !dev->present) {
+	if (!dev->present) {
 		retval = -ENODEV;
 		retval = -ENODEV;
 		goto exit;
 		goto exit;
 	}
 	}