浏览代码

crypto: caam - Kill SPRINTFCAT() with fire

This macro is just like an encyclopedia of string handling done wrong.
This must die. This is so wrong on so many levels.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Horia Geanta <horia.geanta@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Marek Vasut 11 年之前
父节点
当前提交
e22cdcfa13
共有 1 个文件被更改,包括 0 次插入10 次删除
  1. 0 10
      drivers/crypto/caam/error.c

+ 0 - 10
drivers/crypto/caam/error.c

@@ -158,16 +158,6 @@ static const char * const rng_err_id_list[] = {
 	"Secure key generation",
 	"Secure key generation",
 };
 };
 
 
-#define SPRINTFCAT(str, format, param, max_alloc)		\
-{								\
-	char *tmp;						\
-								\
-	tmp = kmalloc(sizeof(format) + max_alloc, GFP_ATOMIC);	\
-	sprintf(tmp, format, param);				\
-	strcat(str, tmp);					\
-	kfree(tmp);						\
-}
-
 static void report_ccb_status(struct device *jrdev, u32 status,
 static void report_ccb_status(struct device *jrdev, u32 status,
 			      const char *error, char *__outstr)
 			      const char *error, char *__outstr)
 {
 {