浏览代码

IB/hns: Use kmalloc_array() in hns_roce_cmd_use_events()

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Markus Elfring 8 年之前
父节点
当前提交
e1d717de5d
共有 1 个文件被更改,包括 3 次插入3 次删除
  1. 3 3
      drivers/infiniband/hw/hns/hns_roce_cmd.c

+ 3 - 3
drivers/infiniband/hw/hns/hns_roce_cmd.c

@@ -299,9 +299,9 @@ int hns_roce_cmd_use_events(struct hns_roce_dev *hr_dev)
 	struct hns_roce_cmdq *hr_cmd = &hr_dev->cmd;
 	struct hns_roce_cmdq *hr_cmd = &hr_dev->cmd;
 	int i;
 	int i;
 
 
-	hr_cmd->context = kmalloc(hr_cmd->max_cmds *
-				  sizeof(struct hns_roce_cmd_context),
-				  GFP_KERNEL);
+	hr_cmd->context = kmalloc_array(hr_cmd->max_cmds,
+					sizeof(*hr_cmd->context),
+					GFP_KERNEL);
 	if (!hr_cmd->context)
 	if (!hr_cmd->context)
 		return -ENOMEM;
 		return -ENOMEM;