Эх сурвалжийг харах

media: i2c: adv748x: Fix cleanup jump on chip identification

The error handling for the adv748x_identify_chip() call erroneously
jumps to the err_cleanup_clients label before the clients have been
established.

Correct this by jumping to the next (and correct) label in the cleanup
code: err_cleanup_dt.

Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Kieran Bingham 7 жил өмнө
parent
commit
e0019f7101

+ 1 - 1
drivers/media/i2c/adv748x/adv748x-core.c

@@ -715,7 +715,7 @@ static int adv748x_probe(struct i2c_client *client,
 	ret = adv748x_identify_chip(state);
 	ret = adv748x_identify_chip(state);
 	if (ret) {
 	if (ret) {
 		adv_err(state, "Failed to identify chip");
 		adv_err(state, "Failed to identify chip");
-		goto err_cleanup_clients;
+		goto err_cleanup_dt;
 	}
 	}
 
 
 	/* Configure remaining pages as I2C clients with regmap access */
 	/* Configure remaining pages as I2C clients with regmap access */