浏览代码

drm/msm: fix unsigned comparison with less than zero

The return from the call to _mixer_stages can be a negative error
code however this is being assigned to an unsigned variable 'stages'
hence the check is always false. Fix this by making 'stages' an
int.

Detected by Coccinelle ("Unsigned expression compared with zero:
stages < 0")

Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Colin Ian King 7 年之前
父节点
当前提交
dfdb3be43e
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c

+ 1 - 1
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c

@@ -297,7 +297,7 @@ static void dpu_hw_ctl_setup_blendstage(struct dpu_hw_ctl *ctx,
 	u32 mixercfg = 0, mixercfg_ext = 0, mix, ext;
 	u32 mixercfg = 0, mixercfg_ext = 0, mix, ext;
 	u32 mixercfg_ext2 = 0, mixercfg_ext3 = 0;
 	u32 mixercfg_ext2 = 0, mixercfg_ext3 = 0;
 	int i, j;
 	int i, j;
-	u8 stages;
+	int stages;
 	int pipes_per_stage;
 	int pipes_per_stage;
 
 
 	stages = _mixer_stages(ctx->mixer_hw_caps, ctx->mixer_count, lm);
 	stages = _mixer_stages(ctx->mixer_hw_caps, ctx->mixer_count, lm);