Browse Source

soc: qcom: qmi: add CONFIG_NET dependency

Access to the socket API and the root network namespace is only available
when networking is enabled:

ERROR: "kernel_sendmsg" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "sock_release" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "sock_create_kern" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "kernel_getsockname" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "init_net" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "kernel_recvmsg" [drivers/soc/qcom/qmi_helpers.ko] undefined!

Adding a dependency on CONFIG_NET lets us build it in all randconfig
builds.

Fixes: 9b8a11e82615 ("soc: qcom: Introduce QMI encoder/decoder")
Acked-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Arnd Bergmann 7 years ago
parent
commit
dea4bd1975
3 changed files with 3 additions and 1 deletions
  1. 1 0
      drivers/remoteproc/Kconfig
  2. 1 1
      drivers/soc/qcom/Kconfig
  3. 1 0
      samples/Kconfig

+ 1 - 0
drivers/remoteproc/Kconfig

@@ -121,6 +121,7 @@ config QCOM_SYSMON
 	tristate "Qualcomm sysmon driver"
 	tristate "Qualcomm sysmon driver"
 	depends on RPMSG
 	depends on RPMSG
 	depends on ARCH_QCOM
 	depends on ARCH_QCOM
+	depends on NET
 	select QCOM_QMI_HELPERS
 	select QCOM_QMI_HELPERS
 	help
 	help
 	  The sysmon driver implements a sysmon QMI client and a handler for
 	  The sysmon driver implements a sysmon QMI client and a handler for

+ 1 - 1
drivers/soc/qcom/Kconfig

@@ -37,7 +37,7 @@ config QCOM_PM
 
 
 config QCOM_QMI_HELPERS
 config QCOM_QMI_HELPERS
 	tristate
 	tristate
-	depends on ARCH_QCOM
+	depends on ARCH_QCOM && NET
 	help
 	help
 	  Helper library for handling QMI encoded messages.  QMI encoded
 	  Helper library for handling QMI encoded messages.  QMI encoded
 	  messages are used in communication between the majority of QRTR
 	  messages are used in communication between the majority of QRTR

+ 1 - 0
samples/Kconfig

@@ -66,6 +66,7 @@ config SAMPLE_QMI_CLIENT
 	tristate "Build qmi client sample -- loadable modules only"
 	tristate "Build qmi client sample -- loadable modules only"
 	depends on m
 	depends on m
 	depends on ARCH_QCOM
 	depends on ARCH_QCOM
+	depends on NET
 	select QCOM_QMI_HELPERS
 	select QCOM_QMI_HELPERS
 	help
 	help
 	  Build an QMI client sample driver, which demonstrates how to
 	  Build an QMI client sample driver, which demonstrates how to