Эх сурвалжийг харах

s390/scm_blk: fix endless loop for requests != REQ_TYPE_FS

The while loop only peeks at the top request in the queue but does
not yet consume it. Since we only handle fs requests, we need to
dequeue and complete all other request command types with error
just in case we would ever receive such an unforeseen request.

Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Steffen Maier 11 жил өмнө
parent
commit
de9587a2f5

+ 5 - 1
drivers/s390/block/scm_blk.c

@@ -223,8 +223,12 @@ static void scm_blk_request(struct request_queue *rq)
 	int ret;
 	int ret;
 
 
 	while ((req = blk_peek_request(rq))) {
 	while ((req = blk_peek_request(rq))) {
-		if (req->cmd_type != REQ_TYPE_FS)
+		if (req->cmd_type != REQ_TYPE_FS) {
+			blk_start_request(req);
+			blk_dump_rq_flags(req, KMSG_COMPONENT " bad request");
+			blk_end_request_all(req, -EIO);
 			continue;
 			continue;
+		}
 
 
 		if (!scm_permit_request(bdev, req)) {
 		if (!scm_permit_request(bdev, req)) {
 			scm_ensure_queue_restart(bdev);
 			scm_ensure_queue_restart(bdev);