Преглед изворни кода

ll_temac: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Thomas Meyer пре 14 година
родитељ
комит
ddf98e6d30
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      drivers/net/ethernet/xilinx/ll_temac_main.c

+ 1 - 1
drivers/net/ethernet/xilinx/ll_temac_main.c

@@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev)
 	struct sk_buff *skb;
 	struct sk_buff *skb;
 	int i;
 	int i;
 
 
-	lp->rx_skb = kzalloc(sizeof(*lp->rx_skb) * RX_BD_NUM, GFP_KERNEL);
+	lp->rx_skb = kcalloc(RX_BD_NUM, sizeof(*lp->rx_skb), GFP_KERNEL);
 	if (!lp->rx_skb) {
 	if (!lp->rx_skb) {
 		dev_err(&ndev->dev,
 		dev_err(&ndev->dev,
 				"can't allocate memory for DMA RX buffer\n");
 				"can't allocate memory for DMA RX buffer\n");