瀏覽代碼

macvlan: Only deliver one copy of the frame to the macvlan interface

This patch intoduces a slight adjustment for macvlan to address the fact
that in source mode I was seeing two copies of any packet addressed to the
macvlan interface being delivered where there should have been only one.

The issue appears to be that one copy was delivered based on the source MAC
address and then the second copy was being delivered based on the
destination MAC address. To fix it I am just treating a unicast address
match as though it is not a match since source based macvlan isn't supposed
to be matching based on the destination MAC anyway.

Fixes: 79cf79abce71 ("macvlan: add source mode")
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Alexander Duyck 7 年之前
父節點
當前提交
dd6b9c2c33
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/net/macvlan.c

+ 1 - 1
drivers/net/macvlan.c

@@ -480,7 +480,7 @@ static rx_handler_result_t macvlan_handle_frame(struct sk_buff **pskb)
 					      struct macvlan_dev, list);
 					      struct macvlan_dev, list);
 	else
 	else
 		vlan = macvlan_hash_lookup(port, eth->h_dest);
 		vlan = macvlan_hash_lookup(port, eth->h_dest);
-	if (vlan == NULL)
+	if (!vlan || vlan->mode == MACVLAN_MODE_SOURCE)
 		return RX_HANDLER_PASS;
 		return RX_HANDLER_PASS;
 
 
 	dev = vlan->dev;
 	dev = vlan->dev;