Bladeren bron

ASoC: Intel: Fix a self assignment in sst_mem_block_alloc_scratch()

Remove a self assignment in sst_mem_block_alloc_scratch(). When calculating
buffer sizes there is no need for statements without effect. Detected by
Coverity: CID 1195249.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Mark Brown <broonie@linaro.org>
Christian Engelmayer 11 jaren geleden
bovenliggende
commit
dd1b94bf49
1 gewijzigde bestanden met toevoegingen van 1 en 3 verwijderingen
  1. 1 3
      sound/soc/intel/sst-firmware.c

+ 1 - 3
sound/soc/intel/sst-firmware.c

@@ -505,9 +505,7 @@ struct sst_module *sst_mem_block_alloc_scratch(struct sst_dsp *dsp)
 
 	/* calculate required scratch size */
 	list_for_each_entry(sst_module, &dsp->module_list, list) {
-		if (scratch->s.size > sst_module->s.size)
-			scratch->s.size = scratch->s.size;
-		else
+		if (scratch->s.size < sst_module->s.size)
 			scratch->s.size = sst_module->s.size;
 	}