Pārlūkot izejas kodu

[media] tuners: remove uneeded checks before release_firmware()

The release_firmware() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Markus Elfring 10 gadi atpakaļ
vecāks
revīzija
dc89cfcf33
2 mainītis faili ar 2 papildinājumiem un 4 dzēšanām
  1. 1 2
      drivers/media/tuners/si2157.c
  2. 1 2
      drivers/media/tuners/xc5000.c

+ 1 - 2
drivers/media/tuners/si2157.c

@@ -196,8 +196,7 @@ warm:
 	return 0;
 
 err:
-	if (fw)
-		release_firmware(fw);
+	release_firmware(fw);
 
 	dev_dbg(&s->client->dev, "failed=%d\n", ret);
 	return ret;

+ 1 - 2
drivers/media/tuners/xc5000.c

@@ -1336,8 +1336,7 @@ static int xc5000_release(struct dvb_frontend *fe)
 
 	if (priv) {
 		cancel_delayed_work(&priv->timer_sleep);
-		if (priv->firmware)
-			release_firmware(priv->firmware);
+		release_firmware(priv->firmware);
 		hybrid_tuner_release_state(priv);
 	}