浏览代码

mtd: maps: sa1100-flash: potential NULL dereference

We check for NULL but then dereference "info->mtd" on the next line.

Fixes: 72169755cf36 ('mtd: maps: sa1100-flash: show parent device in sysfs')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Dan Carpenter 9 年之前
父节点
当前提交
dc01a28d80
共有 1 个文件被更改,包括 3 次插入1 次删除
  1. 3 1
      drivers/mtd/maps/sa1100-flash.c

+ 3 - 1
drivers/mtd/maps/sa1100-flash.c

@@ -230,8 +230,10 @@ static struct sa_info *sa1100_setup_mtd(struct platform_device *pdev,
 
 
 		info->mtd = mtd_concat_create(cdev, info->num_subdev,
 		info->mtd = mtd_concat_create(cdev, info->num_subdev,
 					      plat->name);
 					      plat->name);
-		if (info->mtd == NULL)
+		if (info->mtd == NULL) {
 			ret = -ENXIO;
 			ret = -ENXIO;
+			goto err;
+		}
 	}
 	}
 	info->mtd->dev.parent = &pdev->dev;
 	info->mtd->dev.parent = &pdev->dev;