Browse Source

dscc4: Undefined signed int shift

My analysis in the below mail applies, although the second part is
unnecessary because i isn't used in arithmetic operations here:

https://marc.info/?l=openbsd-tech&m=145377854103866&w=2

Thanks for your time.

Signed-off-by: Michael McConville <mmcco@mykolab.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Michael McConville 9 years ago
parent
commit
db92ea5d4d
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/wan/dscc4.c

+ 1 - 1
drivers/net/wan/dscc4.c

@@ -1626,7 +1626,7 @@ try:
 		if (state & Xpr) {
 		if (state & Xpr) {
 			void __iomem *scc_addr;
 			void __iomem *scc_addr;
 			unsigned long ring;
 			unsigned long ring;
-			int i;
+			unsigned int i;
 
 
 			/*
 			/*
 			 * - the busy condition happens (sometimes);
 			 * - the busy condition happens (sometimes);