瀏覽代碼

PCI: histb: Fix error path of histb_pcie_host_enable()

If clk_prepare_enable() call fails on a particular clock, we should not
call clk_disable_unprepare() on this clock, but on the clocks that
succeed from clk_prepare_enable() previously.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Shawn Guo 7 年之前
父節點
當前提交
db0c25f8aa
共有 1 個文件被更改,包括 3 次插入4 次删除
  1. 3 4
      drivers/pci/dwc/pcie-histb.c

+ 3 - 4
drivers/pci/dwc/pcie-histb.c

@@ -276,13 +276,12 @@ static int histb_pcie_host_enable(struct pcie_port *pp)
 	return 0;
 	return 0;
 
 
 err_aux_clk:
 err_aux_clk:
-	clk_disable_unprepare(hipcie->aux_clk);
-err_pipe_clk:
 	clk_disable_unprepare(hipcie->pipe_clk);
 	clk_disable_unprepare(hipcie->pipe_clk);
-err_sys_clk:
+err_pipe_clk:
 	clk_disable_unprepare(hipcie->sys_clk);
 	clk_disable_unprepare(hipcie->sys_clk);
-err_bus_clk:
+err_sys_clk:
 	clk_disable_unprepare(hipcie->bus_clk);
 	clk_disable_unprepare(hipcie->bus_clk);
+err_bus_clk:
 
 
 	return ret;
 	return ret;
 }
 }