Browse Source

RDMA/amso1100: Add check if cache memory was allocated before freeing it

There is a path in handle_vq() where kmem_cache_free() can be called
with pointer to a local variable.  It can happen if vq_repbuf_alloc()
failed to allocate memory from cache and req is NULL.

The patch adds check if cache memory was allocated before freeing it.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Svetlana Mavrina <another.karnil@gmail.com>
Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Svetlana Mavrina 11 years ago
parent
commit
d9d5713ca6
1 changed files with 2 additions and 1 deletions
  1. 2 1
      drivers/infiniband/hw/amso1100/c2_intr.c

+ 2 - 1
drivers/infiniband/hw/amso1100/c2_intr.c

@@ -169,7 +169,8 @@ static void handle_vq(struct c2_dev *c2dev, u32 mq_index)
 		 * We should never get here, as the adapter should
 		 * We should never get here, as the adapter should
 		 * never send us a reply that we're not expecting.
 		 * never send us a reply that we're not expecting.
 		 */
 		 */
-		vq_repbuf_free(c2dev, host_msg);
+		if (reply_msg != NULL)
+			vq_repbuf_free(c2dev, host_msg);
 		pr_debug("handle_vq: UNEXPECTEDLY got NULL req\n");
 		pr_debug("handle_vq: UNEXPECTEDLY got NULL req\n");
 		return;
 		return;
 	}
 	}