Эх сурвалжийг харах

eeprom: at24: check at24_read/write arguments

So far we completely rely on the caller to provide valid arguments.
To be on the safe side perform an own sanity check.

Cc: stable@vger.kernel.org
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Heiner Kallweit 7 жил өмнө
parent
commit
d9bcd462da

+ 6 - 0
drivers/misc/eeprom/at24.c

@@ -569,6 +569,9 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count)
 	if (unlikely(!count))
 	if (unlikely(!count))
 		return count;
 		return count;
 
 
+	if (off + count > at24->chip.byte_len)
+		return -EINVAL;
+
 	client = at24_translate_offset(at24, &off);
 	client = at24_translate_offset(at24, &off);
 
 
 	ret = pm_runtime_get_sync(&client->dev);
 	ret = pm_runtime_get_sync(&client->dev);
@@ -614,6 +617,9 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count)
 	if (unlikely(!count))
 	if (unlikely(!count))
 		return -EINVAL;
 		return -EINVAL;
 
 
+	if (off + count > at24->chip.byte_len)
+		return -EINVAL;
+
 	client = at24_translate_offset(at24, &off);
 	client = at24_translate_offset(at24, &off);
 
 
 	ret = pm_runtime_get_sync(&client->dev);
 	ret = pm_runtime_get_sync(&client->dev);