소스 검색

ARM: hyp-stub: Zero r0 on successful stub handling

We now return HVC_STUB_ERR when a stub hypercall fails, but we
leave whatever was in r0 on success. Zeroing it on return seems
like a good idea.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <cdall@linaro.org>
Marc Zyngier 8 년 전
부모
커밋
d9118c87d2
2개의 변경된 파일4개의 추가작업 그리고 0개의 파일을 삭제
  1. 2 0
      arch/arm/kernel/hyp-stub.S
  2. 2 0
      arch/arm/kvm/init.S

+ 2 - 0
arch/arm/kernel/hyp-stub.S

@@ -215,8 +215,10 @@ __hyp_stub_do_trap:
 	beq	__hyp_stub_exit
 	beq	__hyp_stub_exit
 
 
 	ldr	r0, =HVC_STUB_ERR
 	ldr	r0, =HVC_STUB_ERR
+	__ERET
 
 
 __hyp_stub_exit:
 __hyp_stub_exit:
+	mov	r0, #0
 	__ERET
 	__ERET
 ENDPROC(__hyp_stub_do_trap)
 ENDPROC(__hyp_stub_do_trap)
 
 

+ 2 - 0
arch/arm/kvm/init.S

@@ -155,8 +155,10 @@ reset:
 	b	exit
 	b	exit
 
 
 1:	ldr	r0, =HVC_STUB_ERR
 1:	ldr	r0, =HVC_STUB_ERR
+	eret
 
 
 exit:
 exit:
+	mov	r0, #0
 	eret
 	eret
 ENDPROC(__kvm_handle_stub_hvc)
 ENDPROC(__kvm_handle_stub_hvc)