Browse Source

[media] v4l: vsp1: remove pads prefix from *_create_pads_links()

The functions that create entities links are called *_create_pads_links()
but the "pads" prefix is redundant since the driver doesn't handle any
other kind of link so it can be removed.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Javier Martinez Canillas 9 years ago
parent
commit
d8a2cf41cc

+ 2 - 2
drivers/media/platform/vsp1/vsp1_drv.c

@@ -261,14 +261,14 @@ static int vsp1_create_entities(struct vsp1_device *vsp1)
 	/* Create links. */
 	/* Create links. */
 	list_for_each_entry(entity, &vsp1->entities, list_dev) {
 	list_for_each_entry(entity, &vsp1->entities, list_dev) {
 		if (entity->type == VSP1_ENTITY_LIF) {
 		if (entity->type == VSP1_ENTITY_LIF) {
-			ret = vsp1_wpf_create_pads_links(vsp1, entity);
+			ret = vsp1_wpf_create_links(vsp1, entity);
 			if (ret < 0)
 			if (ret < 0)
 				goto done;
 				goto done;
 			continue;
 			continue;
 		}
 		}
 
 
 		if (entity->type == VSP1_ENTITY_RPF) {
 		if (entity->type == VSP1_ENTITY_RPF) {
-			ret = vsp1_rpf_create_pads_links(vsp1, entity);
+			ret = vsp1_rpf_create_links(vsp1, entity);
 			if (ret < 0)
 			if (ret < 0)
 				goto done;
 				goto done;
 			continue;
 			continue;

+ 2 - 2
drivers/media/platform/vsp1/vsp1_rpf.c

@@ -285,13 +285,13 @@ error:
 }
 }
 
 
 /*
 /*
- * vsp1_rpf_create_pads_links_create_pads_links() - RPF pads links creation
+ * vsp1_rpf_create_links() - RPF pads links creation
  * @vsp1: Pointer to VSP1 device
  * @vsp1: Pointer to VSP1 device
  * @entity: Pointer to VSP1 entity
  * @entity: Pointer to VSP1 entity
  *
  *
  * return negative error code or zero on success
  * return negative error code or zero on success
  */
  */
-int vsp1_rpf_create_pads_links(struct vsp1_device *vsp1,
+int vsp1_rpf_create_links(struct vsp1_device *vsp1,
 			       struct vsp1_entity *entity)
 			       struct vsp1_entity *entity)
 {
 {
 	struct vsp1_rwpf *rpf = to_rwpf(&entity->subdev);
 	struct vsp1_rwpf *rpf = to_rwpf(&entity->subdev);

+ 2 - 2
drivers/media/platform/vsp1/vsp1_rwpf.h

@@ -50,9 +50,9 @@ static inline struct vsp1_rwpf *to_rwpf(struct v4l2_subdev *subdev)
 struct vsp1_rwpf *vsp1_rpf_create(struct vsp1_device *vsp1, unsigned int index);
 struct vsp1_rwpf *vsp1_rpf_create(struct vsp1_device *vsp1, unsigned int index);
 struct vsp1_rwpf *vsp1_wpf_create(struct vsp1_device *vsp1, unsigned int index);
 struct vsp1_rwpf *vsp1_wpf_create(struct vsp1_device *vsp1, unsigned int index);
 
 
-int vsp1_rpf_create_pads_links(struct vsp1_device *vsp1,
+int vsp1_rpf_create_links(struct vsp1_device *vsp1,
 			       struct vsp1_entity *entity);
 			       struct vsp1_entity *entity);
-int vsp1_wpf_create_pads_links(struct vsp1_device *vsp1,
+int vsp1_wpf_create_links(struct vsp1_device *vsp1,
 			       struct vsp1_entity *entity);
 			       struct vsp1_entity *entity);
 
 
 int vsp1_rwpf_enum_mbus_code(struct v4l2_subdev *subdev,
 int vsp1_rwpf_enum_mbus_code(struct v4l2_subdev *subdev,

+ 2 - 2
drivers/media/platform/vsp1/vsp1_wpf.c

@@ -285,13 +285,13 @@ error:
 }
 }
 
 
 /*
 /*
- * vsp1_wpf_create_pads_links_create_pads_links() - RPF pads links creation
+ * vsp1_wpf_create_links() - RPF pads links creation
  * @vsp1: Pointer to VSP1 device
  * @vsp1: Pointer to VSP1 device
  * @entity: Pointer to VSP1 entity
  * @entity: Pointer to VSP1 entity
  *
  *
  * return negative error code or zero on success
  * return negative error code or zero on success
  */
  */
-int vsp1_wpf_create_pads_links(struct vsp1_device *vsp1,
+int vsp1_wpf_create_links(struct vsp1_device *vsp1,
 			       struct vsp1_entity *entity)
 			       struct vsp1_entity *entity)
 {
 {
 	struct vsp1_rwpf *wpf = to_rwpf(&entity->subdev);
 	struct vsp1_rwpf *wpf = to_rwpf(&entity->subdev);