浏览代码

net: jme: Replace mdelay() with msleep() and usleep_range() in jme_wait_link()

jme_wait_link() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep() and usleep_range().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Jia-Ju Bai 7 年之前
父节点
当前提交
d818c59a8f
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/net/ethernet/jme.c

+ 2 - 2
drivers/net/ethernet/jme.c

@@ -1911,10 +1911,10 @@ jme_wait_link(struct jme_adapter *jme)
 {
 {
 	u32 phylink, to = JME_WAIT_LINK_TIME;
 	u32 phylink, to = JME_WAIT_LINK_TIME;
 
 
-	mdelay(1000);
+	msleep(1000);
 	phylink = jme_linkstat_from_phy(jme);
 	phylink = jme_linkstat_from_phy(jme);
 	while (!(phylink & PHY_LINK_UP) && (to -= 10) > 0) {
 	while (!(phylink & PHY_LINK_UP) && (to -= 10) > 0) {
-		mdelay(10);
+		usleep_range(10000, 11000);
 		phylink = jme_linkstat_from_phy(jme);
 		phylink = jme_linkstat_from_phy(jme);
 	}
 	}
 }
 }