瀏覽代碼

ipvs: remove unnecessary assignment in __ip_vs_get_out_rt

It is a precondition of the function that daddr be equal to dest->addr.ip
if dest is non-NULL, so this additional assignment is just confusing for
stupid engineers like me.

Signed-off-by: Alex Gartrell <agartrell@fb.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
Alex Gartrell 11 年之前
父節點
當前提交
d770108911
共有 1 個文件被更改,包括 0 次插入1 次删除
  1. 0 1
      net/netfilter/ipvs/ip_vs_xmit.c

+ 0 - 1
net/netfilter/ipvs/ip_vs_xmit.c

@@ -293,7 +293,6 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct ip_vs_dest *dest,
 				  &dest->addr.ip, &dest_dst->dst_saddr.ip,
 				  &dest->addr.ip, &dest_dst->dst_saddr.ip,
 				  atomic_read(&rt->dst.__refcnt));
 				  atomic_read(&rt->dst.__refcnt));
 		}
 		}
-		daddr = dest->addr.ip;
 		if (ret_saddr)
 		if (ret_saddr)
 			*ret_saddr = dest_dst->dst_saddr.ip;
 			*ret_saddr = dest_dst->dst_saddr.ip;
 	} else {
 	} else {