Ver Fonte

staging: visorchipset: fix sparse warnings about static declaration

Some functions were prototyped as static but the actual definition
wasn't. While this is valid (the function is static because the two
declarations don't conflict and the first one is static), this makes
sparse unhappy and cause confusion of normal people too.

Signed-off-by: Vincent Bernat <vincent@bernat.im>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vincent Bernat há 11 anos atrás
pai
commit
d746cb55b0
1 ficheiros alterados com 13 adições e 9 exclusões
  1. 13 9
      drivers/staging/unisys/visorchipset/visorchipset_main.c

+ 13 - 9
drivers/staging/unisys/visorchipset/visorchipset_main.c

@@ -351,8 +351,9 @@ static void controlvm_respond_physdev_changestate(CONTROLVM_MESSAGE_HEADER *
 						  msgHdr, int response,
 						  msgHdr, int response,
 						  ULTRA_SEGMENT_STATE state);
 						  ULTRA_SEGMENT_STATE state);
 
 
-ssize_t toolaction_show(struct device *dev, struct device_attribute *attr,
-		char *buf)
+static ssize_t toolaction_show(struct device *dev,
+			       struct device_attribute *attr,
+			       char *buf)
 {
 {
 	u8 toolAction;
 	u8 toolAction;
 
 
@@ -362,8 +363,9 @@ ssize_t toolaction_show(struct device *dev, struct device_attribute *attr,
 	return scnprintf(buf, PAGE_SIZE, "%u\n", toolAction);
 	return scnprintf(buf, PAGE_SIZE, "%u\n", toolAction);
 }
 }
 
 
-ssize_t toolaction_store(struct device *dev, struct device_attribute *attr,
-		const char *buf, size_t count)
+static ssize_t toolaction_store(struct device *dev,
+				struct device_attribute *attr,
+				const char *buf, size_t count)
 {
 {
 	u8 toolAction;
 	u8 toolAction;
 	int ret;
 	int ret;
@@ -381,8 +383,9 @@ ssize_t toolaction_store(struct device *dev, struct device_attribute *attr,
 		return count;
 		return count;
 }
 }
 
 
-ssize_t boottotool_show(struct device *dev, struct device_attribute *attr,
-		char *buf)
+static ssize_t boottotool_show(struct device *dev,
+			       struct device_attribute *attr,
+			       char *buf)
 {
 {
 	ULTRA_EFI_SPAR_INDICATION efiSparIndication;
 	ULTRA_EFI_SPAR_INDICATION efiSparIndication;
 
 
@@ -394,8 +397,9 @@ ssize_t boottotool_show(struct device *dev, struct device_attribute *attr,
 			efiSparIndication.BootToTool);
 			efiSparIndication.BootToTool);
 }
 }
 
 
-ssize_t boottotool_store(struct device *dev, struct device_attribute *attr,
-		const char *buf, size_t count)
+static ssize_t boottotool_store(struct device *dev,
+				struct device_attribute *attr,
+				const char *buf, size_t count)
 {
 {
 	int val, ret;
 	int val, ret;
 	ULTRA_EFI_SPAR_INDICATION efiSparIndication;
 	ULTRA_EFI_SPAR_INDICATION efiSparIndication;
@@ -1897,7 +1901,7 @@ handle_command(CONTROLVM_MESSAGE inmsg, HOSTADDRESS channel_addr)
 	return TRUE;
 	return TRUE;
 }
 }
 
 
-HOSTADDRESS controlvm_get_channel_address(void)
+static HOSTADDRESS controlvm_get_channel_address(void)
 {
 {
 	u64 addr = 0;
 	u64 addr = 0;
 	u32 size = 0;
 	u32 size = 0;