瀏覽代碼

[media] gpsca: remove the risk of a division by zero

As reported by Peter Kovar, there's a potential risk of a division by
zero on calls to jpeg_set_qual() when quality is zero.

As quality can't be 0 or lower than that, add an extra clause to cover
this special case.

Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Luis de Bethencourt 10 年之前
父節點
當前提交
d6d4c0e00f
共有 1 個文件被更改,包括 3 次插入1 次删除
  1. 3 1
      drivers/media/usb/gspca/topro.c

+ 3 - 1
drivers/media/usb/gspca/topro.c

@@ -969,7 +969,9 @@ static void jpeg_set_qual(u8 *jpeg_hdr,
 {
 {
 	int i, sc;
 	int i, sc;
 
 
-	if (quality < 50)
+	if (quality <= 0)
+		sc = 5000;
+	else if (quality < 50)
 		sc = 5000 / quality;
 		sc = 5000 / quality;
 	else
 	else
 		sc = 200 - quality * 2;
 		sc = 200 - quality * 2;