|
@@ -248,7 +248,8 @@ static bool intel_dvo_compute_config(struct intel_encoder *encoder,
|
|
|
intel_dvo->attached_connector->panel.fixed_mode;
|
|
|
struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
|
|
|
|
|
|
- /* If we have timings from the BIOS for the panel, put them in
|
|
|
+ /*
|
|
|
+ * If we have timings from the BIOS for the panel, put them in
|
|
|
* to the adjusted mode. The CRTC will be set up for this mode,
|
|
|
* with the panel scaling set up to source from the H/VDisplay
|
|
|
* of the original mode.
|
|
@@ -296,11 +297,6 @@ static void intel_dvo_pre_enable(struct intel_encoder *encoder,
|
|
|
I915_WRITE(dvo_reg, dvo_val);
|
|
|
}
|
|
|
|
|
|
-/**
|
|
|
- * Detect the output connection on our DVO device.
|
|
|
- *
|
|
|
- * Unimplemented.
|
|
|
- */
|
|
|
static enum drm_connector_status
|
|
|
intel_dvo_detect(struct drm_connector *connector, bool force)
|
|
|
{
|
|
@@ -316,7 +312,8 @@ static int intel_dvo_get_modes(struct drm_connector *connector)
|
|
|
const struct drm_display_mode *fixed_mode =
|
|
|
to_intel_connector(connector)->panel.fixed_mode;
|
|
|
|
|
|
- /* We should probably have an i2c driver get_modes function for those
|
|
|
+ /*
|
|
|
+ * We should probably have an i2c driver get_modes function for those
|
|
|
* devices which will have a fixed set of modes determined by the chip
|
|
|
* (TV-out, for example), but for now with just TMDS and LVDS,
|
|
|
* that's not the case.
|
|
@@ -374,7 +371,7 @@ static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
|
|
|
.destroy = intel_dvo_enc_destroy,
|
|
|
};
|
|
|
|
|
|
-/**
|
|
|
+/*
|
|
|
* Attempts to get a fixed panel timing for LVDS (currently only the i830).
|
|
|
*
|
|
|
* Other chips with DVO LVDS will need to extend this to deal with the LVDS
|
|
@@ -446,7 +443,8 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
|
|
|
uint32_t dpll[I915_MAX_PIPES];
|
|
|
enum port port;
|
|
|
|
|
|
- /* Allow the I2C driver info to specify the GPIO to be used in
|
|
|
+ /*
|
|
|
+ * Allow the I2C driver info to specify the GPIO to be used in
|
|
|
* special cases, but otherwise default to what's defined
|
|
|
* in the spec.
|
|
|
*/
|
|
@@ -457,7 +455,8 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
|
|
|
else
|
|
|
gpio = GMBUS_PIN_DPB;
|
|
|
|
|
|
- /* Set up the I2C bus necessary for the chip we're probing.
|
|
|
+ /*
|
|
|
+ * Set up the I2C bus necessary for the chip we're probing.
|
|
|
* It appears that everything is on GPIOE except for panels
|
|
|
* on i830 laptops, which are on GPIOB (DVOA).
|
|
|
*/
|
|
@@ -465,12 +464,14 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
|
|
|
|
|
|
intel_dvo->dev = *dvo;
|
|
|
|
|
|
- /* GMBUS NAK handling seems to be unstable, hence let the
|
|
|
+ /*
|
|
|
+ * GMBUS NAK handling seems to be unstable, hence let the
|
|
|
* transmitter detection run in bit banging mode for now.
|
|
|
*/
|
|
|
intel_gmbus_force_bit(i2c, true);
|
|
|
|
|
|
- /* ns2501 requires the DVO 2x clock before it will
|
|
|
+ /*
|
|
|
+ * ns2501 requires the DVO 2x clock before it will
|
|
|
* respond to i2c accesses, so make sure we have
|
|
|
* have the clock enabled before we attempt to
|
|
|
* initialize the device.
|
|
@@ -528,7 +529,8 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
|
|
|
|
|
|
intel_connector_attach_encoder(intel_connector, intel_encoder);
|
|
|
if (dvo->type == INTEL_DVO_CHIP_LVDS) {
|
|
|
- /* For our LVDS chipsets, we should hopefully be able
|
|
|
+ /*
|
|
|
+ * For our LVDS chipsets, we should hopefully be able
|
|
|
* to dig the fixed panel mode out of the BIOS data.
|
|
|
* However, it's in a different format from the BIOS
|
|
|
* data on chipsets with integrated LVDS (stored in AIM
|