瀏覽代碼

tipc: Introduce __tipc_nl_bearer_disable

Introduce __tipc_nl_bearer_disable() which doesn't hold RTNL lock.

Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ying Xue 7 年之前
父節點
當前提交
d59d8b77ab
共有 2 個文件被更改,包括 14 次插入6 次删除
  1. 13 6
      net/tipc/bearer.c
  2. 1 0
      net/tipc/bearer.h

+ 13 - 6
net/tipc/bearer.c

@@ -813,7 +813,7 @@ err_out:
 	return err;
 	return err;
 }
 }
 
 
-int tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info)
+int __tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info)
 {
 {
 	int err;
 	int err;
 	char *name;
 	char *name;
@@ -835,19 +835,26 @@ int tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info)
 
 
 	name = nla_data(attrs[TIPC_NLA_BEARER_NAME]);
 	name = nla_data(attrs[TIPC_NLA_BEARER_NAME]);
 
 
-	rtnl_lock();
 	bearer = tipc_bearer_find(net, name);
 	bearer = tipc_bearer_find(net, name);
-	if (!bearer) {
-		rtnl_unlock();
+	if (!bearer)
 		return -EINVAL;
 		return -EINVAL;
-	}
 
 
 	bearer_disable(net, bearer);
 	bearer_disable(net, bearer);
-	rtnl_unlock();
 
 
 	return 0;
 	return 0;
 }
 }
 
 
+int tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info)
+{
+	int err;
+
+	rtnl_lock();
+	err = __tipc_nl_bearer_disable(skb, info);
+	rtnl_unlock();
+
+	return err;
+}
+
 int tipc_nl_bearer_enable(struct sk_buff *skb, struct genl_info *info)
 int tipc_nl_bearer_enable(struct sk_buff *skb, struct genl_info *info)
 {
 {
 	int err;
 	int err;

+ 1 - 0
net/tipc/bearer.h

@@ -188,6 +188,7 @@ extern struct tipc_media udp_media_info;
 #endif
 #endif
 
 
 int tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info);
 int tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info);
+int __tipc_nl_bearer_disable(struct sk_buff *skb, struct genl_info *info);
 int tipc_nl_bearer_enable(struct sk_buff *skb, struct genl_info *info);
 int tipc_nl_bearer_enable(struct sk_buff *skb, struct genl_info *info);
 int tipc_nl_bearer_dump(struct sk_buff *skb, struct netlink_callback *cb);
 int tipc_nl_bearer_dump(struct sk_buff *skb, struct netlink_callback *cb);
 int tipc_nl_bearer_get(struct sk_buff *skb, struct genl_info *info);
 int tipc_nl_bearer_get(struct sk_buff *skb, struct genl_info *info);