ソースを参照

brcmfmac: use kmemdup

Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Muhammad Falak R Wani 9 年 前
コミット
d464fd8b48

+ 1 - 2
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c

@@ -6714,11 +6714,10 @@ struct brcmf_cfg80211_info *brcmf_cfg80211_attach(struct brcmf_pub *drvr,
 		return NULL;
 		return NULL;
 	}
 	}
 
 
-	ops = kzalloc(sizeof(*ops), GFP_KERNEL);
+	ops = kmemdup(&brcmf_cfg80211_ops, sizeof(*ops), GFP_KERNEL);
 	if (!ops)
 	if (!ops)
 		return NULL;
 		return NULL;
 
 
-	memcpy(ops, &brcmf_cfg80211_ops, sizeof(*ops));
 	ifp = netdev_priv(ndev);
 	ifp = netdev_priv(ndev);
 #ifdef CONFIG_PM
 #ifdef CONFIG_PM
 	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_WOWL_GTK))
 	if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_WOWL_GTK))