Explorar el Código

pinctrl: rockchip: missing unlock on error in rockchip_set_pull()

We need to unlock here before returning -EINVAL.

Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Dan Carpenter hace 12 años
padre
commit
d32c3e260f
Se han modificado 1 ficheros con 1 adiciones y 0 borrados
  1. 1 0
      drivers/pinctrl/pinctrl-rockchip.c

+ 1 - 0
drivers/pinctrl/pinctrl-rockchip.c

@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank,
 			data |= (3 << bit);
 			data |= (3 << bit);
 			break;
 			break;
 		default:
 		default:
+			spin_unlock_irqrestore(&bank->slock, flags);
 			dev_err(info->dev, "unsupported pull setting %d\n",
 			dev_err(info->dev, "unsupported pull setting %d\n",
 				pull);
 				pull);
 			return -EINVAL;
 			return -EINVAL;